-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rust-polars to 0.41 #1147
Bump rust-polars to 0.41 #1147
Conversation
Thanks for working on this! Looking at the polars repository it looks like a patch version is planned (pola-rs/polars#17133 (comment)), so perhaps we should wait for that before merging (or release). |
Sure, there's still plenty of work to do anyway but I'll add this in the top post, thanks |
This comment was marked as outdated.
This comment was marked as outdated.
@eitsupi everything passes except the README because of this bug: pola-rs/polars#17308 Let's see how it is handled upstream, there might be another minor release of rust-polars that we could integrate in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work!
A few minor comments.
Thanks for the review. The issue reported upstream has been fixed so later today I will update the rust-polars version to unreleased (unless 0.41.3 is released in the meantime). |
@eitsupi I'll try to deal with checking dots later in the week, and then I think we can release 0.18 |
I want to start checking empty dots after this PR (meaning that we don't release a new version just after this PR)
TODO:
map_batches()
statistics
options in sink/write_parquet