Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-polars to 0.41 #1147

Merged
merged 51 commits into from
Jul 1, 2024
Merged

Bump rust-polars to 0.41 #1147

merged 51 commits into from
Jul 1, 2024

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented Jun 23, 2024

I want to start checking empty dots after this PR (meaning that we don't release a new version just after this PR)


TODO:

  • uncomment commented tests for map_batches()
  • tests for statistics options in sink/write_parquet

@eitsupi
Copy link
Collaborator

eitsupi commented Jun 23, 2024

Thanks for working on this!

Looking at the polars repository it looks like a patch version is planned (pola-rs/polars#17133 (comment)), so perhaps we should wait for that before merging (or release).

@etiennebacher
Copy link
Collaborator Author

Sure, there's still plenty of work to do anyway but I'll add this in the top post, thanks

@etiennebacher etiennebacher marked this pull request as draft June 23, 2024 11:07
@etiennebacher

This comment was marked as outdated.

NEWS.md Outdated Show resolved Hide resolved
@eitsupi eitsupi added this to the 0.18 milestone Jun 27, 2024
@etiennebacher
Copy link
Collaborator Author

@eitsupi everything passes except the README because of this bug: pola-rs/polars#17308

Let's see how it is handled upstream, there might be another minor release of rust-polars that we could integrate in this PR.

@etiennebacher etiennebacher marked this pull request as ready for review June 30, 2024 15:20
@etiennebacher etiennebacher requested a review from eitsupi June 30, 2024 15:21
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!
A few minor comments.

vignettes/userguide.Rmd Outdated Show resolved Hide resolved
R/utils.R Show resolved Hide resolved
@etiennebacher
Copy link
Collaborator Author

etiennebacher commented Jul 1, 2024

Thanks for the review. The issue reported upstream has been fixed so later today I will update the rust-polars version to unreleased (unless 0.41.3 is released in the meantime).

@etiennebacher etiennebacher merged commit b9437f3 into main Jul 1, 2024
32 of 35 checks passed
@etiennebacher etiennebacher deleted the rust-polars-0.41 branch July 1, 2024 22:04
@etiennebacher
Copy link
Collaborator Author

@eitsupi I'll try to deal with checking dots later in the week, and then I think we can release 0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants