-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: make $rename()
's behavior closer to python polars'
#1129
Conversation
$rename()
with a function instead of $rename_with()
$rename()
's behavior closer to python polars'
@etiennebacher This will definitely break tidypolars, but hopefully it is a meaningful change in terms of consistency with Python. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I prefer this order and actually I originally put this old = new
order when I implemented it one year ago but we decided to follow dplyr
for more consistency (#239).
This will definitely break tidypolars
Not a big deal, I'll just need to update the internals but it won't change the external behaviour.
Also for those who use polars
directly, this will clearly error and not just fail silently.
Hmmm, I completely forgot about this. |
A follow up for #1122
old_name = "new_name"
instead ofnew_name = "old_name"