Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $rolling_*_by() expressions #1115

Merged
merged 16 commits into from
Jun 3, 2024
Merged

Add $rolling_*_by() expressions #1115

merged 16 commits into from
Jun 3, 2024

Conversation

etiennebacher
Copy link
Collaborator

@etiennebacher etiennebacher commented May 27, 2024

Part of #1108, close #1082

@etiennebacher etiennebacher changed the title Add $rolling_*_by() expr Add $rolling_*_by() expressions May 27, 2024
@eitsupi eitsupi added this to the 0.17 milestone May 31, 2024
@eitsupi

This comment was marked as resolved.

@etiennebacher

This comment was marked as resolved.

@eitsupi eitsupi marked this pull request as ready for review June 3, 2024 04:16
@eitsupi
Copy link
Collaborator

eitsupi commented Jun 3, 2024

Related issue about argument name pola-rs/polars#16684

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seems working now.

@etiennebacher
Copy link
Collaborator Author

Thanks for finishing this one @eitsupi

@etiennebacher etiennebacher merged commit 3e3eece into main Jun 3, 2024
9 checks passed
@etiennebacher etiennebacher deleted the rolling_by branch June 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split out rolling_*(..., by='foo') into rolling_*_by('foo', ...)
2 participants