Skip to content

Commit

Permalink
move comment above
Browse files Browse the repository at this point in the history
  • Loading branch information
etiennebacher committed Aug 30, 2024
1 parent 7f3605e commit e9a4bef
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/Makevars.in
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ $(SHLIB): $(STATLIB)

CARGOTMP = $(CURDIR)/.cargo

# -z noexecstack added to avoid following error on Ubuntu:
# /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /usr/local/lib/R/site-library/polars/libs/polars.so)`
# https://stackoverflow.com/questions/73435637/how-can-i-fix-usr-bin-ld-warning-trap-o-missing-note-gnu-stack-section-imp/73468271#73468271
$(STATLIB):
if [ -f "$(CURDIR)/../tools/$(LIBNAME)" ]; then \
mkdir -p "$(LIBDIR)" ; \
Expand All @@ -25,9 +28,6 @@ $(STATLIB):
export CARGO_BUILD_JOBS=2; \
fi && \
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
# -z noexecstack added to avoid following error on Ubuntu:
# /usr/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /usr/local/lib/R/site-library/polars/libs/polars.so)`
# https://stackoverflow.com/questions/73435637/how-can-i-fix-usr-bin-ld-warning-trap-o-missing-note-gnu-stack-section-imp/73468271#73468271
cargo build --lib --manifest-path="$(CURDIR)/rust/Cargo.toml" --target-dir "$(TARGET_DIR)" --target="$(TARGET)" \
--profile="$(LIBR_POLARS_PROFILE)" --features="$(LIBR_POLARS_FEATURES)" -z noexecstack

Expand Down

0 comments on commit e9a4bef

Please sign in to comment.