Skip to content

Commit

Permalink
chore: fix typo and revert Rd file incorrect change (#476)
Browse files Browse the repository at this point in the history
  • Loading branch information
eitsupi authored Nov 8, 2023
1 parent 002f509 commit 8646a60
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions man/nanoarrow.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/rust/src/utils/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ pub fn robj_to_rchoice(robj: extendr_api::Robj) -> RResult<String> {
match opt_str {
// NA_CHARACTER not allowed as first element return error
Ok(Some(rstr)) if rstr.is_na() => {
Err(RPolarsErr::new().notachoice("NA_character is not allowed".into()))
Err(RPolarsErr::new().notachoice("NA_character_ is not allowed".into()))
}

// At least one string, return first string
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-robj_to_rchoice.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ test_that("robj_to_rchoice", {

# NA chr not allowed as first element
ctx = test_robj_to_rchoice(NA_character_)$err$contexts()
expect_identical(ctx$NotAChoice, "NA_character is not allowed")
expect_identical(ctx$NotAChoice, "NA_character_ is not allowed")

# empty chr vec not allowed as first element
ctx = test_robj_to_rchoice(character())$err$contexts()
Expand Down

0 comments on commit 8646a60

Please sign in to comment.