remove max_cap requirement, add message

pola-rs · Oct 6, 2023 · 030b240 · 030b240
1 parent 5527802
commit 030b240
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/R/options.R b/R/options.R
@@ -33,10 +33,6 @@ polars_optreq$rpool_cap = list(
   # allow 2 instead of 2L, but doesn't allow 2.5
   must_be_integer = \(x) {
     all(!is.na(x) & is.numeric(x) & x == round(x))
-  },
-  must_be_smaller_than_max = \(x) {
-    max_cap = polars_optenv$rpool_cap_max
-    all(x <= max_cap)
   }
 )
 
@@ -141,6 +137,9 @@ pl$set_options = function(
     assign(args_modified[i], value, envir = polars_optenv)
 
     if (args_modified[i] == "rpool_cap") {
+      if (value > polars_optenv$rpool_cap_max) {
+        message("Setting `rpool_cap` above the default value will likely not generate major speedup.")
+      }
       set_global_rpool_cap(value) |>
         unwrap() |>
         invisible()

diff --git a/tests/testthat/test-rbackground.R b/tests/testthat/test-rbackground.R
@@ -78,9 +78,9 @@ test_that("reset rpool_cap", {
 
 test_that("rpool errors", {
   rpool_cap_max = pl$options$rpool_cap_max
-  expect_error(
+  expect_message(
     pl$set_options(rpool_cap = rpool_cap_max + 1),
-    "must be smaller than the maximum capacity"
+    "above the default value"
   )
   expect_error(
     pl$set_options(rpool_cap = c(1, 2)),