Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy warn redundant casts #4055

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Conversation

zundertj
Copy link
Collaborator

@zundertj zundertj commented Jul 17, 2022

Lets get this in, otherwise we may be having too many different mypy changes.

Fixes mypy "warn_redundant_casts" in #4044.

@github-actions github-actions bot added the python Related to Python Polars label Jul 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #4055 (c53bebc) into master (8406450) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4055      +/-   ##
==========================================
- Coverage   62.87%   62.85%   -0.02%     
==========================================
  Files         449      449              
  Lines       74543    74543              
==========================================
- Hits        46868    46854      -14     
- Misses      27675    27689      +14     
Impacted Files Coverage Δ
...polars-core/src/chunked_array/iterator/par/list.rs 95.23% <0.00%> (-4.77%) ⬇️
polars/polars-arrow/src/utils.rs 74.15% <0.00%> (-1.13%) ⬇️
polars/polars-core/src/series/series_trait.rs 12.05% <0.00%> (-1.07%) ⬇️
...s/polars-core/src/series/implementations/floats.rs 59.13% <0.00%> (-0.93%) ⬇️
...lars/polars-core/src/series/implementations/mod.rs 87.17% <0.00%> (-0.77%) ⬇️
polars/polars-core/src/chunked_array/cast.rs 72.22% <0.00%> (-0.70%) ⬇️
polars/polars-time/src/series/mod.rs 56.00% <0.00%> (-0.67%) ⬇️
py-polars/polars/testing.py 93.88% <0.00%> (-0.56%) ⬇️
polars/polars-core/src/series/mod.rs 53.32% <0.00%> (-0.48%) ⬇️
...lars/polars-core/src/series/arithmetic/borrowed.rs 35.56% <0.00%> (-0.41%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8406450...c53bebc. Read the comment docs.

@zundertj zundertj changed the title WIP: Mypy warn redundant casts Draft: Mypy warn redundant casts Jul 17, 2022
@zundertj zundertj marked this pull request as draft July 17, 2022 14:09
@zundertj zundertj changed the title Draft: Mypy warn redundant casts Mypy warn redundant casts Jul 17, 2022
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

PS: You can mark this review as "ready for review" with a button below here somewhere.

@ritchie46 ritchie46 marked this pull request as ready for review July 18, 2022 06:30
@ritchie46 ritchie46 merged commit 20134a9 into pola-rs:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants