Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix join literal behavior #20477

Merged
merged 4 commits into from
Dec 27, 2024
Merged

fix: Fix join literal behavior #20477

merged 4 commits into from
Dec 27, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Dec 27, 2024

Rewrite IR so that literals get expanded.

closes #20061
closes #9603

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 99.20635% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (0a7814b) to head (128fc63).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/conversion/join.rs 99.09% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20477      +/-   ##
==========================================
+ Coverage   78.98%   78.99%   +0.01%     
==========================================
  Files        1563     1563              
  Lines      220570   220650      +80     
  Branches     2490     2492       +2     
==========================================
+ Hits       174218   174307      +89     
+ Misses      45779    45770       -9     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcrumiller
Copy link
Contributor

mcrumiller commented Dec 27, 2024

Based on the PR title, does this also close #9603?

@ritchie46
Copy link
Member Author

Based on the PR title, does this also close #9603?

Yes!

@ritchie46 ritchie46 merged commit 8e27477 into main Dec 27, 2024
25 checks passed
@ritchie46 ritchie46 deleted the join branch December 27, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants