Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Dispatch slice/filter lowering properly #20390

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Dec 20, 2024

This centralizes a remaining todo!() on the slice for negative slices, and fixed a non-streaming predicate bug in one instance (wasn't translated) and a todo!() in another case.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Dec 20, 2024
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #20390 will improve performances by 26.99%

Comparing orlp:lower-ir-refactor (f0ea4f6) with main (2c9e503)

Summary

⚡ 1 improvements
✅ 40 untouched benchmarks

Benchmarks breakdown

Benchmark main orlp:lower-ir-refactor Change
test_pdsh_q18 15.9 ms 12.5 ms +26.99%

@ritchie46 ritchie46 merged commit d309fd0 into pola-rs:main Dec 20, 2024
19 checks passed
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (db1684d) to head (f0ea4f6).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20390      +/-   ##
==========================================
- Coverage   79.10%   78.89%   -0.21%     
==========================================
  Files        1572     1567       -5     
  Lines      219958   219960       +2     
  Branches     2465     2465              
==========================================
- Hits       173991   173542     -449     
- Misses      45399    45850     +451     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants