Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(rust): Add proper distributor to new-streaming parquet reader #20372

Merged
merged 8 commits into from
Dec 27, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Dec 19, 2024

The same should probably be done for the CSV one as well.

@github-actions github-actions bot added performance Performance issues or improvements rust Related to Rust Polars labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (8e27477) to head (f8b2208).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...polars-stream/src/nodes/io_sources/parquet/init.rs 0.00% 54 Missing ⚠️
.../polars-stream/src/nodes/io_sources/parquet/mod.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20372      +/-   ##
==========================================
+ Coverage   78.99%   79.01%   +0.02%     
==========================================
  Files        1563     1563              
  Lines      220650   220592      -58     
  Branches     2492     2492              
==========================================
+ Hits       174304   174306       +2     
+ Misses      45773    45713      -60     
  Partials      573      573              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


(raw_morsel_receivers, raw_morsel_distributor_task_handle)
(raw_morsel_receivers, AbortOnDropHandle(join_task))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping this join_task AbortOnDropHandle here doesn't cancel all of the previous tasks - the handles for those tasks should be individually wrapped in AbortOnDropHandle as soon as they are created.

@orlp orlp force-pushed the new-stream-parquet-distr branch from 00aee74 to f8b2208 Compare December 27, 2024 13:58
@ritchie46 ritchie46 merged commit a35c66c into pola-rs:main Dec 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants