-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(rust): Add proper distributor to new-streaming parquet reader #20372
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20372 +/- ##
==========================================
+ Coverage 78.99% 79.01% +0.02%
==========================================
Files 1563 1563
Lines 220650 220592 -58
Branches 2492 2492
==========================================
+ Hits 174304 174306 +2
+ Misses 45773 45713 -60
Partials 573 573 ☔ View full report in Codecov by Sentry. |
|
||
(raw_morsel_receivers, raw_morsel_distributor_task_handle) | ||
(raw_morsel_receivers, AbortOnDropHandle(join_task)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping this join_task
AbortOnDropHandle
here doesn't cancel all of the previous tasks - the handles for those tasks should be individually wrapped in AbortOnDropHandle
as soon as they are created.
00aee74
to
f8b2208
Compare
The same should probably be done for the CSV one as well.