Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Deprecate explicit Categorical physical ordering #19055

Closed
wants to merge 1 commit into from

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Oct 1, 2024
Ordering by order of appearance (`'physical'`, default)
Ordering physical categories (`'physical'`, default).
This is an implementation detail and not guaranteed.
Note that this option will be removed in future versions.
or string value (`'lexical'`).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left half a sentence here.

@Shoeboxam
Copy link

Will dropping ordering affect .cut(...).to_physical(), where the order of categories coming out of cut is significant?

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 98.49624% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (2c9e503) to head (5692b8d).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...rates/polars-plan/src/plans/optimizer/set_order.rs 98.09% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19055      +/-   ##
==========================================
+ Coverage   78.91%   78.93%   +0.02%     
==========================================
  Files        1567     1561       -6     
  Lines      219928   219804     -124     
  Branches     2465     2471       +6     
==========================================
- Hits       173549   173505      -44     
+ Misses      45811    45731      -80     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 closed this Dec 21, 2024
@ritchie46 ritchie46 deleted the order branch December 21, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants