Update with iPhone 15 devices #839
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mbrandonw @stephencelis Can you accept this PR for adding new Devices ? |
vincenzpascarella
approved these changes
Mar 14, 2024
luispadron
reviewed
Mar 31, 2024
|
|
||
| public static func iPhone15Plus(_ orientation: ViewImageConfig.Orientation) -> UITraitCollection { | ||
| let base: [UITraitCollection] = [ | ||
| .init(forceTouchCapability: .available), |
There was a problem hiding this comment.
Not sure these match the actual values, and other places: https://github.com/playbook-ui/playbook-ios/blob/798f686a6d73318185f85d844876274e91f1f3a2/Sources/Playbook/SnapshotSupport/SnapshotDevice.swift#L739
iPhone X series was the last to support force touch afaik
There was a problem hiding this comment.
Hi @luispadron can you approve it ?
There was a problem hiding this comment.
I don't have maintainer access unfortunately
luispadron
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.