-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added 2022 lineup - new devices (14, 14 Pro, 14 Pro, 14 ProMax) #718
base: main
Are you sure you want to change the base?
Conversation
It would be great to get this merged to get the new devices! Any idea of what is holding this up? 🤔 |
Can we get this reviewed or merged? |
Can we get an update on when this change will be merged in and if the plan is to continue to actively maintain this library as there hasn't been any merge to master for about 6 months now. |
Can we get this merged in order to support iPhone 14? |
@stephencelis I see you have merged several other PRs in this repo. Is there a process this PR needs to go through to get merged? Our team is working on updating to the latest devices now and would love to go to iPhone 14 if possible. Thanks! |
Is this library a dead project? |
@mbrandonw / @stephencelis is Point-Free still maintaining this repo? |
Hi @tinder-owenthomas, yes we do maintain this repo, and merge pull requests that we think are important. However, this project, more so than any of our others, has parts that need constant updating due to Apple's release schedule, and it's just not feasible to keep up-to-date with it all the time. For example, even in this PR we think there are potentially some mistakes, such as having forceTouchCapability set to Further, we feel that a lot of these little utilities can be implemented outside the library, and probably should be. For example, the contents of the PR can be copy-pasted into any project. It does not require any internals from the library. The fact that we haven't yet merged this PR should not hold anyone up from bringing it into their own projects. And the same is true of almost all of the snapshot strategies that are very difficult to maintain in the face of Apple's ever changing frameworks and bugs. In the end we'd like to evolve this library into a state where nearly all of the strategies are moved out into separate projects, largely supported by the community, so that all that is left is the core of the snapshotting tools. |
So you won't be adding the support for the iPhone 14 devices? |
Hi @rfodge, we are open to merging it, but there are some potential problems with it currently, such as auditing the usage of But I want to re-iterate that the library does not need to support these devices. The |
Ok I will give that a try thank you for the quick response |
Half a year has passed :( |
This PR adds the 14, iPhone14Plus, iPhone14Pro, and iPhone14ProMax devices for snapshot testing.
I took the numbers for the device config from: https://useyourloaf.com/blog/iphone-14-screen-sizes/
I believe the traits should be the same as iPhone 13