Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix campaign application link in mail to organizer and mail to admin #674

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix campaign application link in mail to organizer and mail to admin #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7068eb6
chore: remove unused deps
gparlakov Jul 14, 2024
5ef7de2
fix: wrong link when applying for campaign
gparlakov Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/api/src/campaign-application/campaign-application.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

describe('CampaignApplicationService', () => {
let service: CampaignApplicationService
let configService: ConfigService

Check warning on line 30 in apps/api/src/campaign-application/campaign-application.service.spec.ts

View workflow job for this annotation

GitHub Actions / Run API tests 

'configService' is defined but never used

const mockPerson = {
...personMock,
Expand Down Expand Up @@ -192,14 +192,14 @@

const emailAdminData = {
campaignApplicationName: mockSingleCampaignApplication.campaignName,
campaignApplicationLink: `${process.env.APP_URL}/admin/campaigns/${mockSingleCampaignApplication.id}`,
campaignApplicationLink: `${process.env.APP_URL}/admin/campaigns/edit/${mockSingleCampaignApplication.id}`,
email: mockPerson.email as string,
firstName: mockPerson.firstName,
}

const emailOrganizerData = {
campaignApplicationName: mockSingleCampaignApplication.campaignName,
campaignApplicationLink: `${process.env.APP_URL}/campaign/applications/${mockSingleCampaignApplication.id}`,
campaignApplicationLink: `${process.env.APP_URL}/campaigns/application/${mockSingleCampaignApplication.id}`,
email: mockPerson.email as string,
firstName: mockPerson.firstName,
}
Expand Down
4 changes: 2 additions & 2 deletions apps/api/src/campaign-application/campaign-application.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export class CampaignApplicationService {
campaignApplicationName,
campaignApplicationLink: `${this.configService.get(
'APP_URL',
)}/admin/campaigns/${campaignApplicationId}`,
)}/admin/campaigns/edit/${campaignApplicationId}`,
email: person.email as string,
firstName: person.firstName,
}
Expand All @@ -119,7 +119,7 @@ export class CampaignApplicationService {
campaignApplicationName,
campaignApplicationLink: `${this.configService.get(
'APP_URL',
)}/campaign/applications/${campaignApplicationId}`,
)}/campaigns/application/${campaignApplicationId}`,
email: person.email as string,
firstName: person.firstName,
}
Expand Down
Loading