Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bugfix smap rss l2 sss v6 #305

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Dec 11, 2024

Description

Overview of work done

  • Update the indexer function to account for 3 dimension on the
  • update indexer when the lon lat has dims xdim_grid and ydim_grid
  • make indexer account for when the x index is on 1 and y index is on 0 we don't need to transpose the dimensions
  • update the logging when we have empty dataset in indexer and when we are selecting everything in indexer

Overview of verification done

  • pytest locally make sure still pass test
  • tested with SMAP_RSS_L2_SSS_V6 granules to make sure subsettings correct

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@jamesfwood jamesfwood merged commit 6960ea8 into develop Dec 19, 2024
3 checks passed
@jamesfwood jamesfwood deleted the feature/bugfix_SMAP_RSS_L2_SSS_V6 branch December 19, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistaken report of subsetted area being equal to original granule
2 participants