Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix shapefile #223

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Feature/fix shapefile #223

merged 2 commits into from
Jan 5, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Jan 3, 2024

Description

  • Fix issues when shape file passes in a 3 dimensional coordinate instead of only 2

Overview of work done

  • Add an extra optional argument to scale function to account for 3 dimensional coordinate

Overview of verification done

  • Tested locally in cli to subset with a 3 dimensional shapefile

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 requested a review from jamesfwood January 3, 2024 18:21
@sliu008 sliu008 merged commit 5926e37 into develop Jan 5, 2024
2 checks passed
@sliu008 sliu008 deleted the feature/fix_shapefile branch January 5, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood