Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PnPjsExample to SPFx 1.20.0 and switched to fluent ui instead of office-ui-fabric due to compatibility issue #5315

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

gretchunkim
Copy link
Contributor

What's in this Pull Request?

Upgraded SPFx from 1.15 to 1.20. In addition, office-ui-fabric is swapped with fluent ui due to compatibility issue.

Node Version

Node version used: v18.20.4

Checklist

  • My pull request affects only ONE sample.
  • My sample builds without any warnings
  • I have updated the README.md file's Version history. For new samples, created a new README.md file matching this template
  • My README.md has at least one static high-resolution screenshot (i.e. not a GIF) located in the assets folder.
  • My README.md contains complete setup instructions, including pre-requisites and permissions required
  • My solution includes a .nvmrc file indicating the version of Node.js

Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👏👏👏
I added a few adjustments and we are ready to go 🚀

@Adam-it Adam-it merged commit cc17f7f into pnp:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Using @pnp/js and ReactJS web part to latest version of SPFx - Refresh Rangers Hacktoberfest Event
2 participants