Upgraded react-datatable SPFx to version 1.20.0 #5312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-it
requested changes
Oct 22, 2024
There was a problem hiding this comment.
@mohammadamer awesome work 👏👏👏👏
I managed to build the solution and play with it.
I noticed some tiny details we could sort out before we merge. Please do give them a double check 🙏
|
@Adam-it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Upgraded react-datatable SPFx to version 1.20.0
Fixed a bug when exporting to PDF
Node Version
20.16.0
Node version used:
20.16.0
Checklist
README.mdfile's Version history. For new samples, created a newREADME.mdfile matching this templateREADME.mdhas at least one static high-resolution screenshot (i.e. not a GIF) located in theassetsfolder.README.mdcontains complete setup instructions, including pre-requisites and permissions required.nvmrcfile indicating the version of Node.js