Upgraded list search webpartto spfx 1.20.0 #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 1, 2024 10:34
|
Thank you for opening a PR to our samples repo and helping us upgrade our project 👍 |
1 similar comment
|
Thank you for opening a PR to our samples repo and helping us upgrade our project 👍 |
Adam-it
requested changes
Oct 7, 2024
There was a problem hiding this comment.
@albegut Awesome work so far 👏👏👏👏 and a very nice refactor 😍. You Rock 🤩
I left a few comments we could sort out before we merge, Please do give them a double check 🙏
Also in the sample assets folder you will a sample.json file which we also need to update.
We should update the updateDateTime and also change the SPFx version to 1.20.0.
This files has the metadata that is used in MS sample gallery so it's important to keep this algined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Upgraded the SharePoint Framework to v1.20.0
Node Version
Checklist
README.mdfile's Version history. For new samples, created a newREADME.mdfile matching this templateREADME.mdhas at least one static high-resolution screenshot (i.e. not a GIF) located in theassetsfolder.README.mdcontains complete setup instructions, including pre-requisites and permissions required.nvmrcfile indicating the version of Node.js