Merge pull request #5281 from a1mery/js-advanced-commenting-upgrade

pnp · Oct 12, 2024 · 51befab · 51befab
2 parents ca2581b + 4adf438
commit 51befab
Show file tree

Hide file tree

Showing 9 changed files with 29,038 additions and 35,313 deletions.
diff --git a/samples/js-advanced-commenting/.devcontainer/devcontainer.json b/samples/js-advanced-commenting/.devcontainer/devcontainer.json
@@ -1,7 +1,7 @@
 // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer
 {
-  "name": "SPFx 1.17.0",
-  "image": "docker.io/m365pnp/spfx:1.17.0",
+  "name": "SPFx 1.20.0",
+  "image": "docker.io/m365pnp/spfx:1.20.0",
   // Set *default* container specific settings.json values on container create.
   "settings": {},
   // Add the IDs of extensions you want installed when the container is created.

diff --git a/samples/js-advanced-commenting/.nvmrc b/samples/js-advanced-commenting/.nvmrc
@@ -1 +1 @@
-v16.13.0
+v18.18.0
diff --git a/samples/js-advanced-commenting/.yo-rc.json b/samples/js-advanced-commenting/.yo-rc.json
@@ -2,7 +2,7 @@
   "@microsoft/generator-sharepoint": {
     "isCreatingSolution": true,
     "environment": "spo",
-    "version": "1.17.0",
+    "version": "1.20.0",
     "libraryName": "modern-page-comments",
     "libraryId": "cfa8dbcf-b32d-4de0-a6ba-af486007c2f2",
     "packageManager": "npm",
@@ -11,7 +11,7 @@
     "nodeVersion": "14.18.2",
     "sdkVersions": {
       "@microsoft/microsoft-graph-client": "3.0.2",
-      "@microsoft/teams-js": "2.9.1"
+      "@microsoft/teams-js": "2.24.0"
     }
   }
 }
diff --git a/samples/js-advanced-commenting/README.md b/samples/js-advanced-commenting/README.md
@@ -48,8 +48,8 @@
 
 This sample is optimally compatible with the following environment configuration:
 
-![SPFx 1.17.0](https://img.shields.io/badge/SPFx-1.17.0-green.svg)
-![Node.js v16.13+](https://img.shields.io/badge/Node.js-v16.13+-green.svg)
+![SPFx 1.20.0](https://img.shields.io/badge/SPFx-1.20.0-green.svg)
+![Node.js v18](https://img.shields.io/badge/Node.js-v18-green.svg)
 ![Compatible with SharePoint Online](https://img.shields.io/badge/SharePoint%20Online-Compatible-green.svg)
 ![Does not work with SharePoint 2019](https://img.shields.io/badge/SharePoint%20Server%202019-Incompatible-red.svg "SharePoint Server 2019 requires SPFx 1.4.1 or lower")
 ![Does not work with SharePoint 2016 (Feature Pack 2)](https://img.shields.io/badge/SharePoint%20Server%202016%20(Feature%20Pack%202)-Incompatible-red.svg "SharePoint Server 2016 Feature Pack 2 requires SPFx 1.1")
@@ -85,6 +85,7 @@ Version|Date|Comments
 1.2.0.0|March 09, 2023|Upgraded to 1.16.1
 1.3.0.0|June 10, 2023|Upgraded to 1.17.0
 1.3.0.1|March 11, 2024|`this.pageurl` must be initialized before building `this.pastAtachmentPath`
+1.4.0.0|October 03, 2024|Upgraded to 1.20.0
 
 ## Minimal Path to Awesome
 

diff --git a/samples/js-advanced-commenting/assets/sample.json b/samples/js-advanced-commenting/assets/sample.json
@@ -9,7 +9,7 @@
       "This component is developed for the advanced usage of commenting the page or article etc. Page Comments lists will be created to store the comments."
     ],
     "creationDateTime": "2020-02-05",
-    "updateDateTime": "2024-03-11",
+    "updateDateTime": "2024-10-03",
     "products": [
       "SharePoint"
     ],
@@ -20,7 +20,7 @@
       },
       {
         "key": "SPFX-VERSION",
-        "value": "1.17.0"
+        "value": "1.20.0"
       },
       {
         "key": "PNPCONTROLS",

diff --git a/samples/js-advanced-commenting/config/package-solution.json b/samples/js-advanced-commenting/config/package-solution.json
@@ -3,7 +3,7 @@
   "solution": {
     "name": "Advanced Comments Box",
     "id": "cfa8dbcf-b32d-4de0-a6ba-af486007c2f2",
-    "version": "1.3.0.0",
+    "version": "1.4.0.0",
     "includeClientSideAssets": true,
     "isDomainIsolated": false,
     "developer": {