Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates why this cli docs #6452

Closed
wants to merge 5 commits into from
Closed

Updates why this cli docs #6452

wants to merge 5 commits into from

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Oct 26, 2024

🎯 Aim

Based on our internal discussion the aim is to update the 'Why this CLI' docs page to provide more details and advantages of our product.

📸 Result

image

@Adam-it Adam-it added the docs label Oct 26, 2024
Copy link
Member

@waldekmastykarz waldekmastykarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Some suggestions for improvement.

docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
@Adam-it
Copy link
Member Author

Adam-it commented Nov 1, 2024

@waldekmastykarz, @milanholemans ready for another check?

@milanholemans milanholemans self-assigned this Dec 15, 2024
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks from my side 😊

docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft December 15, 2024 00:32
@Adam-it Adam-it marked this pull request as ready for review December 17, 2024 10:36
@Adam-it
Copy link
Member Author

Adam-it commented Dec 17, 2024

@milanholemans thanks for your review. I applied most of your comments. Do you wanna take the PR for another spin 🙂?

Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few tiny remarks, nothing more to add. Nice job!

docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
docs/docs/about/why-cli.mdx Outdated Show resolved Hide resolved
@Adam-it
Copy link
Member Author

Adam-it commented Dec 19, 2024

Apart from a few tiny remarks, nothing more to add. Nice job!

Thank you 👍
Let's get this shipped 🚢⚓

@milanholemans milanholemans added this to the v10.2 milestone Dec 22, 2024
@milanholemans
Copy link
Contributor

Merged manually, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants