Extends 'spo list get' command with support for retrieving any default list in a given site #6447
Conversation
tmaestrini
changed the title
|
Thanks, we'll have a look at it ASAP. |
Adam-it
added
the
hacktoberfest-accepted
|
@tmaestrini I added the |
|
@Adam-it Thanks a lot! :) Looking forward to my very first contribution on the M365 cli when this PR gets closed! ;) |
|
Do you want me to do something on this? Is there anything missing? |
@tmaestrini I don't think there is anything missing. We have a lot of PRs to process but we will try to catch up with this ASAP |
There was a problem hiding this comment.
Nice work @tmaestrini, I suggest we make some minor changes.
There was a problem hiding this comment.
Let's add another example to the docs where we retrieve the default list.
There was a problem hiding this comment.
Good idea, will do so 👍.
I will include this example in the "Examples" section on https://pnp.github.io/cli-microsoft365/cmd/spo/list/list-get/:
Get the default document library located in the specified site.
m365 spo list get --webUrl https://contoso.sharepoint.com/sites/project-x
Can you tell me: the response differs in this case because the script returns the properties of the default libraries. How should I document this in the "Response" section?
There was a problem hiding this comment.
Does the response differ? I just did a quick check, and the response looks the same, no?
| it('retrieves the default list in the specified site by providing a webUrl', async () => { | ||
| const defaultSiteList = { ...listResponse, BaseTemplate: 101, ParentWebUrl: "/", ListItemEntityTypeFullName: "SP.Data.Shared_x0020_DocumentsItem" }; | ||
|
|
||
| sinon.stub(request, 'get').resolves({ |
There was a problem hiding this comment.
Let's check that the right URL was passed.
There was a problem hiding this comment.
@milanholemans What do you mean by this statement? I mean we we test if a user only passes the webUrl option. Then – and only then – the default document library is returned.
I probably don't understand how or why you want to check if the correct URL has been passed?
There was a problem hiding this comment.
Just like in other tests, instead of a sinon.stub(...).resolves(...), we should do sinon.stub(...).callsFake(opts => if (opts.url === <URL>) return result;. This way we ensure that the right request was made.
Closes #5856.
This PR substitutes PR #6445