Updates workflows to build & test Docusaurs. Closes #4754 #4789
Conversation
Jwaegebaert
force-pushed
the
docs/workflows
branch
2 times, most recently
from
770b64d to
56b2cd0
Compare
.github/workflows/release_next.yml
Outdated
| working-directory: docs | ||
|
|
||
| - name: Deploy to GitHub Pages | ||
| uses: peaceiris/actions-gh-pages@v3 |
There was a problem hiding this comment.
Is there no github-owned package for publishing pages?
There was a problem hiding this comment.
Didn't find anything simular directly. Docusaurus suggests to work with this popular third-party deployment action
https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-docusaurus
There was a problem hiding this comment.
How about this? https://github.com/actions/deploy-pages
There was a problem hiding this comment.
Nice find. That appears to work as well 😄
https://github.com/Jwaegebaert/cli-build-test/actions/runs/4779137491
Although it looks like it doesn't create a commit to the branch gh-pages. Is that common behavior for GitHub action deploys to pages?
There was a problem hiding this comment.
Good question. Let's find out
There was a problem hiding this comment.
Instead of deploying the build to a separate branch, they do a deployment to a GitHub Environement. https://github.com/Jwaegebaert/cli-build-test/deployments
There was a problem hiding this comment.
Just to clarify: that's sufficient for our purposes, right? I can see the docs on your repo just fine (excl. the mismatched URL but that's deliberate) but not sure if that's from a previous deployment or not.
There was a problem hiding this comment.
That should be sufficient enough. My docs is just because of the quick setup 😅
milanholemans
force-pushed
the
docs-migration
branch
from
054fe2e to
686e8b9
Compare
Jwaegebaert
force-pushed
the
docs/workflows
branch
from
35c2f31 to
4a06416
Compare
|
@waldekmastykarz can I assign this one to you since you already did a review? Also I think you are more experienced with GH pipelines than I am 😄 |
milanholemans
force-pushed
the
docs-migration
branch
from
4531b0d to
19cd0da
Compare
Jwaegebaert
force-pushed
the
docs/workflows
branch
2 times, most recently
from
535717e to
c98f9fe
Compare
Jwaegebaert
force-pushed
the
docs-migration
branch
from
19cd0da to
47e1cc2
Compare
Jwaegebaert
force-pushed
the
docs/workflows
branch
from
c98f9fe to
859c10e
Compare
milanholemans
force-pushed
the
docs-migration
branch
from
47e1cc2 to
a896c04
Compare
milanholemans
force-pushed
the
docs/workflows
branch
from
859c10e to
c481ae9
Compare
milanholemans
force-pushed
the
docs-migration
branch
from
a896c04 to
53b0bd4
Compare
milanholemans
force-pushed
the
docs/workflows
branch
from
c481ae9 to
d510b9f
Compare
milanholemans
force-pushed
the
docs-migration
branch
from
53b0bd4 to
c215a9b
Compare
milanholemans
force-pushed
the
docs/workflows
branch
from
d510b9f to
cfc1f13
Compare
milanholemans
force-pushed
the
docs-migration
branch
2 times, most recently
from
0ccf65e to
b5b7244
Compare
milanholemans
force-pushed
the
docs/workflows
branch
from
cfc1f13 to
d41c4b2
Compare
Jwaegebaert
force-pushed
the
docs/workflows
branch
from
d41c4b2 to
63fad98
Compare
milanholemans
force-pushed
the
docs-migration
branch
from
b5b7244 to
79747ba
Compare
milanholemans
force-pushed
the
docs/workflows
branch
from
63fad98 to
6d7bc90
Compare
Jwaegebaert
force-pushed
the
docs-migration
branch
from
79747ba to
68e9799
Compare
milanholemans
force-pushed
the
docs-migration
branch
from
68e9799 to
bc88a8f
Compare
milanholemans
force-pushed
the
docs/workflows
branch
from
6d7bc90 to
57ae2da
Compare
Closes #4754