Add AdHoc step implementer that can be used to run a command or script from any step

[RyanMillerC]

Purpose

Implements #131. Adds ad-hoc shared step implementer that can be used to run a command or script from any step.

Breaking?

No

Integration Testing

I did not do integration testing. I did add unit tests for new code though! 😎

[itewk]

Two questions:

if it’s going to run as bash shouldn’t it be called the Bash step or something?

what’s the point of this. If there is no inputs or outputs to normalize and be able to parse results from why call the PSR at all, why not just call the script direct? The intent of the PSR (was) to be able to abstract common API interactions by normalizing inputs and outputs. But since this allows someone to run anything there is nothing to normalize that can then be consumed by future steps.

[dwinchell]

@itewk I think it's useful and could be made useful. Right now it lets you:

1. reuse the psr-based workflow definition. You don't have to tinker with minimal.groovy to run some one-off that doesn't have a step implementer. That's especially useful if you're prototyping something.
2. obfuscate outputs
3. use the standard reporting, including the stdout as an artifact

It could also be enhanced to do things like
4) pass in values from previous steps, like version numbers or generated urls

Granted, writing your own step implementer in python does all that, but people who are prototyping or who aren't developers might not want to do that.

[dwinchell]

@itewk As far as calling it "AdHoc" instead of "Bash" ... some people feel opposed to the idea of encouraging users to use PSR without writing step implementers in python. Calling it AdHoc helps to communicate that they are forgoing some of the benefits of writing your own step implementer.

[itewk]

@dwinchell okay on all accounts.

[codecov]

Codecov Report

Merging #291 (9f3736b) into main (bbc65e5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #291   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       107    +1     
  Lines         4317      4351   +34     
=========================================
+ Hits          4317      4351   +34     

Flag	Coverage Δ
pytests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s_step_runner/step_implementers/shared/__init__.py	100.00% <100.00%> (ø)
...gos_step_runner/step_implementers/shared/ad_hoc.py	100.00% <100.00%> (ø)
...os_step_runner/step_implementers/tag_source/git.py	100.00% <0.00%> (ø)
..._runner/step_implementers/generate_metadata/git.py	100.00% <0.00%> (ø)
...implementers/generate_metadata/semantic_version.py	100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[RyanMillerC]

@dwinchell Updated to use shell util instead of bash (removed bash all together). Should be good to go.