Enhancement: Download oscap tailoring file from a private git repo

[christophermay07]

Purpose

This PR enhances the existing OpenSCAP step runner to allow for pulling down an OpenSCAP definition tailoring file from a private git repository.

Breaking?

No

Integration Testing

TBD; currently in progress

[codecov]

Codecov Report

Merging #263 (9d1aa4f) into main (bbc65e5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          106       106           
  Lines         4317      4334   +17     
=========================================
+ Hits          4317      4334   +17     

Flag	Coverage Δ
pytests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...unner/step_implementers/shared/openscap_generic.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[itewk]

The entire point of https://github.com/ploigos/ploigos-step-runner/blob/main/src/ploigos_step_runner/utils/file.py#L139 was to make it so we wouldn't have to have the "if file / if repo" logic all ovcer the palce, we could jsut have it in one place. so why not update https://github.com/ploigos/ploigos-step-runner/blob/main/src/ploigos_step_runner/utils/file.py#L139 to be able to take credentials and provide them to git if given so this logic isn't just in openscap but anywhere we need to pull a file?

[dwinchell]

The entire point of https://github.com/ploigos/ploigos-step-runner/blob/main/src/ploigos_step_runner/utils/file.py#L139 was to make it so we wouldn't have to have the "if file / if repo" logic all ovcer the palce, we could jsut have it in one place. so why not update https://github.com/ploigos/ploigos-step-runner/blob/main/src/ploigos_step_runner/utils/file.py#L139 to be able to take credentials and provide them to git if given so this logic isn't just in openscap but anywhere we need to pull a file?

I agree this would be better. I'm also okay merging this because the work is already done but opening an issue to refactor it.

[dwinchell]

@christophermay07 based on our out of band conversation, i thought you were going to stop work on this (I may have misunderstood). I see more commits. Do you want me to review again instead?

[christophermay07]

@christophermay07 based on our out of band conversation, i thought you were going to stop work on this (I may have misunderstood). I see more commits. Do you want me to review again instead?

@dwinchell since this PR was so old, I rebased again main to ensure that nothing merged recently caused any testing or linting conflicts with my existing PR. Rebase did not have any conflicts, so no need to review again!