-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
callback method can not be invoked in await method #901
Open
ghost
wants to merge
1,202
commits into
playframework:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late Add loadModels params in fixture.tag to be compatible with master version Fix parameters positions in fixtures for loading as template option
the result of "Time.parseDuration(duration)" was treated as an Integer, and this can exceed the limit of Integer.MAX_VALUE very easily, we can cast to Long to prevent this issue.
Used text data type can be set via "evolution.PLAY_EVOLUTIONS.textType"
…rt=<port number> Use the framework id when parsing the jpda.port so that we can specify a separate fixed port to use for debugging per mode Fixed bug where adding the option '-f' would actually always randomise the jpda_port Add documentation for the following command line options: http.port, https.port, jpda.port and pid_file
…r webservice wanted messages of why the request was bad)
…aking our customers.....passwords now can have colon with this fix
Conflicts: framework/src/play/jobs/JobsPlugin.java
…ies as well as JPABase
Conflicts: framework/src/play/db/DBPlugin.java framework/src/play/db/jpa/JPAPlugin.java
…lay1 into tazmaniax-lighthouse-1748-master-patch Conflicts: framework/src/play/db/DBConfig.java
…own unique promise to gain functionality
[#1735] add return to unbind method
travis -> cloudbees
image size
[#1763] Check for empty uploads when binding File[]
….1.35 Conflicts: framework/dependencies.yml
* refactor(JPAPlugin): move JPAModelLoader to its own file
disabled play's hibernate interceptor, giving back transitive persistence Conflicts: framework/src/play/db/jpa/HibernateInterceptor.java framework/src/play/db/jpa/JPAPlugin.java
switch back to standard play save() behaviour Conflicts: framework/src/play/db/jpa/HibernateInterceptor.java framework/src/play/db/jpa/JPAPlugin.java
* [#1944] refactor(HibernateInterceptor): fix tabulation in file Conflicts: documentation/manual/configuration.textile framework/src/play/db/jpa/HibernateInterceptor.java
[#1944] hibernate update to v4.2.19
Someone has been mixing tabs and spaces in here...
* [#1713] feat(command): add documentation for param --force-server in command install
** remove some deprecated method call and used the new ones Conflicts: framework/src/play/server/FileService.java framework/src/play/server/PlayHandler.java
…l play.ant.PlayConfigurationLoadTask
…haracter(+, .) * Add ipv4Address validation test * fix typo in PhoneTest method
…e displaying the exception if (only available on PlayException)
Conflicts: framework/src/play/data/FileUpload.java
Callback method can not be invoked in await method when refreshing page after sending the request. I don't know whether it designed for any deep reasons, but I think program should continue even if the request channel is closed when refreshing or closing the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback method can not be invoked in await method when refreshing page after sending the request.
I don't know whether it designed for any deep reasons, but I think program should continue even if the request channel is closed when
refreshing or closing the page.