Fix compilation with OpenCV4 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modified some parts of the main CMakeLists to compile with C++11, and also search for an installation of OpenCV.
Additionally, changes to header includes were made, as well as adding other missing headers so they legacy C API functions are properly recognized with the latest iteration of OpenCV.
I redefined
cvScalarin a couple of files, and also convertedcvLoadImageto now usecv::imreadinstead by converting it withcvarrToMat.Someone with the proper knowledge, please review this properly before merging.
Let me know if I missed anything or if I did something wrong.
This PR should fix Issue #28 which I created some time ago.