-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse and publish hashtags in notes when posting #1693
Conversation
# Conflicts: # CHANGELOG.md
👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that we have this feature now! One request and one thought:
- NIP-27 says that hashtags must be lowercased. I think if someone inputs
#HaShTaG
we need to add it to the tags ashashtag
. - I'm not sure how hashtags work elsewhere, but I don't like that they are only terminated with whitespace or the end of the string. I expected punctuation to also terminate them. For example, I expected
check out my #hashtag!
to add the hashtaghashtag
. I'm flexible on this one.
# Conflicts: # CHANGELOG.md
@mplorentz thanks for the request and thought! I've implemented both, so it's ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Issues covered
https://github.com/verse-pbc/issues/issues/44
Description
Parses hashtags from posts and includes them as actual hashtags as defined in NIP-24.
How to test
#photography
)t: photography
in it.Screenshots/Video