Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP delete all notes on startup #1464

Closed
wants to merge 3 commits into from
Closed

Conversation

mplorentz
Copy link
Member

Issues covered

This is part of #1426

Description

I want to do something unorthodox and merge this PR so that others can test it on staging. It's not production-ready code and I will make sure to revert it before it gets deployed to users.

This makes these changes:

  • Simplifies the DatabaseCleaner routine so that it just drops all Events
  • Changes the app startup process so that it waits for the DatabaseCleaner to complete before showing any UI

This has one bad side effect:

  • It breaks our code that tries to republish events that failed to publish to relays

We are getting lot of reports of content not loading and poor performance from Rabble, Linda, and Sebastian. I can't reproduce the issues but I have a hunch that this might help and I want to test that cheaply before I spend more time going down this route. If this does help their issues I will revert this PR and redo it in a cleaner way that doesn't break our republishing routine.

How to test

  1. Launch Nos
  2. Make sure nothing is broken and you don't see any regressions.

@joshuatbrown
Copy link
Contributor

I'm fine with this if we need to, but as an alternative, could you use the TestFlight Dev deployment action to deploy a Dev build for them instead? I'm not 100% sure it works, but it looks like Martin successfully deployed from it 3 weeks ago, so fingers crossed? 🤞

@mplorentz
Copy link
Member Author

I'm fine with this if we need to, but as an alternative, could you use the TestFlight Dev deployment action to deploy a Dev build for them instead? I'm not 100% sure it works, but it looks like Martin successfully deployed from it 3 weeks ago, so fingers crossed? 🤞

good idea, I'll try that.

@mplorentz mplorentz closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants