Fix Grafana plugin release job #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… were introduced Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
commented
Dec 6, 2024
Comment on lines
-115
to
+119
| plugincheck ${{ steps.metadata.outputs.archive }} | ||
| plugincheck2 ${{ steps.metadata.outputs.archive }} |
There was a problem hiding this comment.
plugincheck (v1) is deprecated and failed with the following error before I upgraded it:
~/work/grafana-plugin/grafana-plugin/plugin-validator/pkg/cmd/plugincheck ~/work/grafana-plugin/grafana-plugin
~/work/grafana-plugin/grafana-plugin
888 888 888
888 888 888
888 888 888
.d88888 .d88b. 88888b. 888d888 .d88b. .d8888b 8888b. 888888 .d88b. .d88888
d88" 888d8P Y8b888 "88b888P" d8P Y8bd88P" "88b888 d8P Y8bd88" 888
888 88888888888888 888888 88888888888 .d888888888 88888888888 888
Y88b 888Y8b. 888 d88P888 Y8b. Y88b. 888 888Y88b. Y8b. Y88b 888
"Y88888 "Y8888 88888P" 888 "Y8888 "Y8888P"Y888888 "Y888 "Y8888 "Y88888
888
888
888
**plugincheck V1 is no longer supported.**
Use V2 instead: plugincheck2
To install it see README https://github.com/grafana/plugin-validator
You are running plugincheck in a Github Action.
Replace your github action plugincheck-related code with the following:
- name: Lint plugin
run: |
git clone https://github.com/grafana/plugin-validator
pushd ./plugin-validator/pkg/cmd/plugincheck2
go install
popd
plugincheck2 ${{ steps.metadata.outputs.archive }}
ddelnano
commented
Dec 6, 2024
Comment on lines
-118
to
+122
| uses: actions/create-release@v1 | ||
| uses: softprops/action-gh-release@v2 |
There was a problem hiding this comment.
GitHub's actions/create-release has been deprecated since 2021. The softprops option is one of the recommended alternatives and handles the upload-plugin-asset and upload-checksum-asset steps as well.
|
@pixie-io/grafana this is ready for review. |
aimichelle
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Grafana plugin release job
When I tried to release the v0.10.0 version, I was unable to since the release job failed. This job will likely need more changes (see #106), but this will unblock publishing the v0.10.0 release.
Testing done: