Revert fixes for uprobe names that are too long #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengruizhe
pushed a commit
to chengruizhe/bcc
that referenced
this pull request
Jan 18, 2023
…for -v option
Add additional information and change format of backtrace
- add symbol base offset, dso name, dso base offset
- symbol and dso info is included if it's available in target binary
- changed format:
INDEX ADDR [SYMBOL+OFFSET] (MODULE+OFFSET)
Print backtrace of ip if it failed to get syms.
Before:
# offcputime -v
psiginfo
vscanf
__snprintf_chk
[unknown]
[unknown]
[unknown]
[unknown]
[unknown]
sd_event_exit
sd_event_dispatch
sd_event_run
[unknown]
__libc_start_main
[unknown]
- systemd-journal (204)
1
xas_load
xas_find
filemap_map_pages
__handle_mm_fault
handle_mm_fault
do_page_fault
do_translation_fault
do_mem_abort
do_el0_ia_bp_hardening
el0_ia
xas_load
--
failed to get syms
- PmLogCtl (138757)
1
After:
# offcputime -v
#0 0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
pixie-io#1 0xffffffc01009a93c el0_svc_handler+0x34
pixie-io#2 0xffffffc010084a08 el0_svc+0x8
pixie-io#3 0xffffffc01018b7e8 __arm64_sys_clock_nanosleep+0x0
--
pixie-io#4 0x0000007fa0bffd14 clock_nanosleep+0x94 (/usr/lib/libc-2.31.so+0x9ed14)
pixie-io#5 0x0000007fa0c0530c nanosleep+0x1c (/usr/lib/libc-2.31.so+0xa430c)
pixie-io#6 0x0000007fa0c051e4 sleep+0x34 (/usr/lib/libc-2.31.so+0xa41e4)
pixie-io#7 0x000000558a5a9608 flb_loop+0x28 (/usr/bin/fluent-bit+0x52608)
pixie-io#8 0x000000558a59f1c4 flb_main+0xa84 (/usr/bin/fluent-bit+0x481c4)
pixie-io#9 0x0000007fa0b85124 __libc_start_main+0xe4 (/usr/lib/libc-2.31.so+0x24124)
iovisor#10 0x000000558a59d828 _start+0x34 (/usr/bin/fluent-bit+0x46828)
- fluent-bit (1238)
1
#0 0xffffffc01027daa4 generic_copy_file_checks+0x334
pixie-io#1 0xffffffc0102ba634 __handle_mm_fault+0x8dc
pixie-io#2 0xffffffc0102baa20 handle_mm_fault+0x168
pixie-io#3 0xffffffc010ad23c0 do_page_fault+0x148
pixie-io#4 0xffffffc010ad27c0 do_translation_fault+0xb0
pixie-io#5 0xffffffc0100816b0 do_mem_abort+0x50
pixie-io#6 0xffffffc0100843b0 el0_da+0x1c
pixie-io#7 0xffffffc01027daa4 generic_copy_file_checks+0x334
--
pixie-io#8 0x0000007f8dc12648 [unknown]
pixie-io#9 0x0000007f8dc0aef8 [unknown]
iovisor#10 0x0000007f8dc1c990 [unknown]
iovisor#11 0x0000007f8dc08b0c [unknown]
iovisor#12 0x0000007f8dc08e48 [unknown]
iovisor#13 0x0000007f8dc081c8 [unknown]
- PmLogCtl (2412)
1
Fixed: iovisor#3884
Signed-off-by: Eunseon Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
93f866a and 44d4590 introduced a fix that, when the uprobe name is too long, truncates the original name and attaches a random string to the uprobe name, stored in a
name_map_.After discussion, we decided that using the hash of the name is a better fix, which also eliminates the need for the
name_map_.This diff reverts the fixes using a random string and another fix using hash of the uprobe name will follow.