Lookup table #596
Draft
Lookup table #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Siedlaczek <[email protected]>
Signed-off-by: Michal Siedlaczek <[email protected]>
Signed-off-by: Michal Siedlaczek <[email protected]>
We construct codecs as a shared pointer to `BlockCodec` and without a virtual destructor, only the destructor of the base class is called. This has not caused any real issues because the codecs do not do any memory management, but this is now for correctness and future-proofing. Signed-off-by: Michal Siedlaczek <[email protected]>
Signed-off-by: Michal Siedlaczek <[email protected]>
elshize
force-pushed
the
lookup-table
branch
from
9bd847d to
0aba011
Compare
Changelog-added: New lookup table implementation available Signed-off-by: Michal Siedlaczek <[email protected]>
elshize
force-pushed
the
lookup-table
branch
from
0aba011 to
aac2dbd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 93.84% 93.87% +0.02%
==========================================
Files 81 81
Lines 3897 3916 +19
==========================================
+ Hits 3657 3676 +19
Misses 240 240 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, depends on #595