Implement PscSource, PscSink, and Table API's to close the gap on Flink 1.15.1 API's #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PscInternalProducer
jeffxiang
changed the title
psc-flink/src/main/java/com/pinterest/flink/connector/psc/PscFlinkConfiguration.java
Show resolved
Hide resolved
Thanks Vahid! I think the PSC core module has supporting changes that need a more careful review. The other modules (psc-flink) contain changes that are mostly ported logic from upstream Kafka connector. |
…pared to FlinkPscProducer and Consumer
vahidhashemian
approved these changes
Nov 8, 2024
| @@ -1604,6 +1604,44 @@ public MessageId committed(TopicUriPartition topicUriPartition) throws ConsumerE | |||
| } | |||
| } | |||
|
|
|||
| // TODO: unit test this | |||
| public Collection<MessageId> committed(Collection<TopicUriPartition> topicUriPartitions) throws ConsumerException, ConfigurationException { | |||
There was a problem hiding this comment.
Please add javadoc.
Since the implementation is a bit more involved that piggybacking on the above implementation, we should also add some integration tests.
vahidhashemian
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes big changes to psc-flink:
Unit, integration, and functional tests were performed against 1.15.1 platform binaries.