Wrap metrics() in sychronized block to try and prevent CME

pinterest · Dec 13, 2024 · 30a5b22 · 30a5b22
1 parent 70d83e2
commit 30a5b22
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/psc/src/main/java/com/pinterest/psc/consumer/PscConsumer.java b/psc/src/main/java/com/pinterest/psc/consumer/PscConsumer.java
@@ -1902,7 +1902,9 @@ public Map<MetricName, Metric> metrics() throws ClientException {
         ensureOpen();
         Map<MetricName, Metric> metrics = new ConcurrentHashMap<>();
         for (PscBackendConsumer<K, V> backendConsumer : backendConsumers) {
-            metrics.putAll(backendConsumer.metrics());
+            synchronized (backendConsumer.metrics()) {
+                metrics.putAll(backendConsumer.metrics());
+            }
         }
         return metrics;
     }