Skip to content

Commit

Permalink
Fixes up the Carthage build for downstream projects (#280)
Browse files Browse the repository at this point in the history
  • Loading branch information
garrettmoon authored Aug 21, 2020
1 parent e0fc640 commit 7d1f63a
Show file tree
Hide file tree
Showing 40 changed files with 1,163 additions and 59 deletions.
2 changes: 1 addition & 1 deletion Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "pinterest/PINOperation" "1.1"
github "pinterest/PINOperation" "1.2"
80 changes: 80 additions & 0 deletions Carthage/Checkouts/PINOperation/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
---
name: CI

on:
push:
branches:
- master
- 'releases/*'
pull_request:
branches:
- master

jobs:
build:
name: Build
runs-on: macOS-latest
strategy:
matrix:
platform: ['iOS Simulator,name=iPhone 8']
steps:
- uses: actions/checkout@v2
- name: Analyze and Test
run: |
xcodebuild clean analyze test \
-destination "platform=${{ matrix.platform }}" \
-sdk "iphonesimulator" \
-project PINOperation.xcodeproj \
-scheme PINOperation \
ONLY_ACTIVE_ARCH=NO \
CODE_SIGNING_REQUIRED=NO \
CLANG_ANALYZER_OUTPUT=plist-html \
CLANG_ANALYZER_OUTPUT_DIR="$(pwd)/clang" \
| xcpretty
if [[ -n `find $(pwd)/clang -name "*.html"` ]] ; then rm -rf $(pwd)/clang; exit 1; fi
rm -rf $(pwd)/clang
cocoapods:
name: CocoaPods
runs-on: macOS-latest
steps:
- uses: actions/checkout@v2
- name: Lint
run: pod lib lint
carthage:
name: Carthage
runs-on: macOS-latest
steps:
- uses: actions/checkout@v2
- name: Build
run: carthage build --no-skip-current
spm:
name: Swift Package Manager tests
runs-on: macOS-latest
steps:
- uses: actions/checkout@v2
- name: Test
run: swift test
example:
name: Build Example project
runs-on: macOS-latest
strategy:
matrix:
platform: ['iOS Simulator,name=iPhone 8']
steps:
- uses: actions/checkout@v2
- name: Install Pods
run: cd Example && pod install
- name: Build
run: |
cd Example && xcodebuild clean analyze \
-destination "platform=${{ matrix.platform }}" \
-sdk "iphonesimulator" \
-workspace PINOperationExample.xcworkspace \
-scheme PINOperationExample \
ONLY_ACTIVE_ARCH=NO \
CODE_SIGNING_REQUIRED=NO \
CLANG_ANALYZER_OUTPUT=plist-html \
CLANG_ANALYZER_OUTPUT_DIR="$(pwd)/clang" \
| xcpretty
if [[ -n `find $(pwd)/clang -name "*.html"` ]] ; then rm -rf $(pwd)/clang; exit 1; fi
rm -rf $(pwd)/clang
3 changes: 3 additions & 0 deletions Carthage/Checkouts/PINOperation/.github_changelog_generator
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
issues=false
since-tag=1.1.1
future-release=1.2
3 changes: 3 additions & 0 deletions Carthage/Checkouts/PINOperation/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,6 @@ Carthage/Build
# Bundler
.bundle
vendor

# Example project
Example/Pods

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions Carthage/Checkouts/PINOperation/BUCK
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
apple_library(
name = 'PINOperation',
exported_headers = glob(['PINOperation/*.h']),
modular = True,
exported_headers = glob(['Source/*.h']),
srcs =
glob(['PINOperation/*.m']),
glob(['Source/*.m']),
preprocessor_flags = ['-fobjc-arc'],
lang_preprocessor_flags = {
'C': ['-std=gnu99'],
Expand Down
27 changes: 25 additions & 2 deletions Carthage/Checkouts/PINOperation/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
## master
* Add your own contributions to the next release on the line below this with your name.
## [1.2](https://github.com/Pinterest/PINOperation/tree/1.2) (2020-06-30)

[Full Changelog](https://github.com/Pinterest/PINOperation/compare/1.1.2...1.2)

**Merged pull requests:**

- Swift Package Manager support [\#32](https://github.com/pinterest/PINOperation/pull/32) ([martinpucik](https://github.com/martinpucik))
- Add Carthage for watchOS, dependent by PINCache [\#31](https://github.com/pinterest/PINOperation/pull/31) ([dreampiggy](https://github.com/dreampiggy))
- Fix analyzing [\#30](https://github.com/pinterest/PINOperation/pull/30) ([garrettmoon](https://github.com/garrettmoon))
- Standardize our GitHub Actions CI workflow [\#29](https://github.com/pinterest/PINOperation/pull/29) ([jparise](https://github.com/jparise))
- Github CI [\#26](https://github.com/pinterest/PINOperation/pull/26) ([rahul-malik](https://github.com/rahul-malik))
- Fixes coalesce operation race condition [\#24](https://github.com/pinterest/PINOperation/pull/24) ([zhongwuzw](https://github.com/zhongwuzw))

## [1.1.2](https://github.com/Pinterest/PINOperation/tree/1.1.2) (2019-06-11)

[Full Changelog](https://github.com/Pinterest/PINOperation/compare/1.1.1...1.1.2)

**Merged pull requests:**

- Modernizing project [\#21](https://github.com/pinterest/PINOperation/pull/21) ([garrettmoon](https://github.com/garrettmoon))
- Updates BUCK build file to match source layout. [\#20](https://github.com/pinterest/PINOperation/pull/20) ([RCacheaux](https://github.com/RCacheaux))
- 1.1.1 release [\#19](https://github.com/pinterest/PINOperation/pull/19) ([garrettmoon](https://github.com/garrettmoon))

## 1.1.1 -- 2018 February 3
* Cleanup warnings [garrett](https://github.com/garrettmoon)

## 1.1 -- 2017 October 7
* Deprecate addOperation: in favor of scheduleOperation: [garrett](https://github.com/garrettmoon)
Expand Down
4 changes: 3 additions & 1 deletion Carthage/Checkouts/PINOperation/CI/exclude-from-build.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
[
"^plans/",
"^docs/",
"^CI/exclude-from-build.json$"
"^CI/exclude-from-build.json$",
"^README.md$",
"^CHANGELOG.md$"
]
40 changes: 40 additions & 0 deletions Carthage/Checkouts/PINOperation/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Code of Conduct

At Pinterest, we work hard to ensure that our work environment is welcoming
and inclusive to as many people as possible. We are committed to creating this
environment for everyone involved in our open source projects as well. We
welcome all participants regardless of ability, age, ethnicity, identified
gender, religion (or lack there of), sexual orientation and socioeconomic
status.

This code of conduct details our expectations for upholding these values.

## Good behavior

We expect members of our community to exhibit good behavior including (but of
course not limited to):

- Using intentional and empathetic language.
- Focusing on resolving instead of escalating conflict.
- Providing constructive feedback.

## Unacceptable behavior

Some examples of unacceptable behavior (again, this is not an exhaustive
list):

- Harassment, publicly or in private.
- Trolling.
- Sexual advances (this isn’t the place for it).
- Publishing other’s personal information.
- Any behavior which would be deemed unacceptable in a professional environment.

## Recourse

If you are witness to or the target of unacceptable behavior, it should be
reported to Pinterest at [email protected]. All reporters will
be kept confidential and an appropriate response for each incident will be
evaluated.

If the maintainers do not uphold and enforce this code of conduct in
good faith, community leadership will hold them accountable.
Loading

0 comments on commit 7d1f63a

Please sign in to comment.