Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action return values #9

Closed
wants to merge 3 commits into from
Closed

Action return values #9

wants to merge 3 commits into from

Conversation

lukicmarko
Copy link

Implementation:

  • created FIleHelper class that parse output file and returns results: result_bucket_url, test_lab_console_url , test_failed

@bffcorreia bffcorreia self-requested a review August 3, 2018 10:22
@bffcorreia
Copy link
Contributor

Hi @lukicmarko!

First of all thank you for your PR :) I will review it soon.

Just two small questions before starting the review:
1- Can you point me with a use case for this feature? It's easier to understand what is happening with the use case in mind :)
2- Can you fix the rubocop offenses? I need them fixed before merging your PR and deploy a new version of the plugin :) To run the tests and code style validations you can simply run rake. To fix some offenses automatically try to run rubocop -a. If after that there are still offenses, you need to fix them by hand.

Cheers

@lukicmarko
Copy link
Author

  • since this is very old change I will create new pullrequest

@lukicmarko lukicmarko closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants