Merge pull request #24 from cwdt/master

Check if tracking_url holds content
picqer · Dec 9, 2018 · 96ae66e · 96ae66e
2 parents d26eea6 + 00ac064
commit 96ae66e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Picqer/Carriers/SendCloud/Parcel.php b/src/Picqer/Carriers/SendCloud/Parcel.php
@@ -53,6 +53,7 @@ class Parcel extends Model
         'requestShipment',
         'order_number',
         'tracking_number',
+        'tracking_url',
         'weight',
         'total_insured_value',
         'sender_address',
@@ -77,8 +78,7 @@ class Parcel extends Model
 
     public function getTrackingUrl()
     {
-        // SendCloud now gives us this undocumented field, so if it exists use this
-        if ( ! empty($this->tracking_url)) {
+        if (strlen($this->tracking_url) > 0) {
             return $this->tracking_url;
         }