Close windows from taskbar thumbnail #17477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Hi @iglosiggio it would be nice to add some tests, at least behavioral.
Maybe no need to add layout tests, but testing the fade out and simulating the click should be ncie.
| @@ -87,15 +87,18 @@ SystemWindow >> taskbarButtonClicked [ | |||
| SystemWindow >> taskbarButtonEntered: aButton event: evt in: aMorph [ | |||
| "The mouse has entered out taskbar button. | |||
| Show a thumbnail." | |||
| | taskbar | | |||
| taskbar := aButton owner. | |||
| borderStyle: (self taskbarThumbnailNormalBorderStyleFor: aWindow); | ||
| cornerStyle: (self taskbarThumbnailCornerStyleFor: answer). | ||
| ^answer | ||
| ^ TaskbarThumbnailMorph for: aWindow taskbarButton: aButton theme: self |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a sketch on adding a "close window" button to the taskbar thumbnail we show by default. This behavior is currently doable (just do right click on the corresponding taskbar button and click "close") but this is a bit easier when searching a window across the whole taskbar.
The implementation is not up to any decent standard so any suggestions wil be highly appreciated.
This was done on the last pharo sprint with help from @tesonep.