-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added test infrastructure for SDK reliability #23
Open
0xObsidian
wants to merge
2
commits into
phantom:main
Choose a base branch
from
0xObsidian:0xObsidian/test-infrastructure-for-SDK-reliability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: added test infrastructure for SDK reliability #23
0xObsidian
wants to merge
2
commits into
phantom:main
from
0xObsidian:0xObsidian/test-infrastructure-for-SDK-reliability
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xObsidian
changed the title
feat: test infrastructure for SDK reliability
feat: added test infrastructure for SDK reliability
Dec 9, 2024
0xObsidian
force-pushed
the
0xObsidian/test-infrastructure-for-SDK-reliability
branch
from
December 9, 2024 19:26
9aef996
to
1fa936d
Compare
@tian000 |
|
This commit introduces comprehensive test coverage and continuous integration checks to maintian the wallet SDK's reliability and prevent regressions: Description ----------- - Position enum validation - createPhantom configuration handling (validates SDK initialization) - Script tag creation and attributes (verifies DOM manipulation) - URL parameter handling (confirms correct Phantom connection params) - Edge cases and invalid inputs (improves error handling) Impact ------ - Enables safe future iterations and feature additions - Prevents breaking changes in core SDK functionality - Maintains 100% test coverage for critical user-facing features Testing the introduced `feat` ----------------------------- 1. To execute the test suite, run: ``` yarn test ``` 2. To verify coverage metrics, run: ``` yarn test:coverage ``` 3. For interactive granular testing during development, run: ``` yarn test:watch ``` Available commands in watch mode: - `a` - run all tests - `f` - run only failed tests - `p` - filter by filename pattern - `t` - filter by test name pattern - `Enter` - trigger a test run **Note**: Tests auto-rerun on file changes 4. To execute the introduced CI integration: - Create a PR targeting `main` - Check GitHub Actions 5. To remove dev build artifacts, run: ``` yarn clean ```
0xObsidian
force-pushed
the
0xObsidian/test-infrastructure-for-SDK-reliability
branch
from
December 17, 2024 06:04
1fa936d
to
fe70397
Compare
Hi @illuminated-shade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive test coverage and continuous integration checks to maintian the wallet SDK's reliability and prevent regressions:
Description
Impact
Testing the introduced
feat
yarn test
Available commands in watch mode:
a
- run all testsf
- run only failed testsp
- filter by filename patternt
- filter by test name patternEnter
- trigger a test runNote: Tests auto-rerun on file changes
To execute the introduced CI integration:
main
To remove dev build artifacts, run: