Add the ability to search DPS locations by City name #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phamleduy04, I've created this PR to add support for searching by Could you please review and let me know if this approach aligns with the project's goals? Additionally, I noticed that CodeFactor is flagging some linting issues that I couldn't resolve using Prettier. Are the linting rules up to date, or is there something else I should address? Thanks for your time! |
|
Thanks for your PR! I tested it, and this works 👍. I will fix the prettier problem and then merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated types to acoomodate cityName
Updated config
Updated logic to search by cityname