New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing null of type string is deprecated warning #16651

Open

raicabogdan wants to merge 2 commits into phalcon:5.0.x from raicabogdan:5.0.x

raicabogdan commented Sep 26, 2024

Hello!

Type: bug fix
Link to issue: [BUG]: Cant get all cookies #16649

In raising this pull request, I confirm the following:

I have read and understood the Contributing Guidelines
I have checked that another pull request for this purpose does not exist
I wrote some tests for this PR
I have updated the relevant CHANGELOG
I have created a PR for the documentation about this change

Small description of change:
Ensure null type deprecation warnings are avoided, happens if someone creates the same cookie twice eg:

$this->cookies->set("test", "test value");
$this->cookies->set("test", "test value");

it will cause the deprecated warning message.

Thanks

raicabogdan added 2 commits

September 26, 2024 23:19


          correct cookie default arguments to avoid deprecated null assignments

855c085


          updating changelog

c5743b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet