Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T16430 logger interpolation #16445

Merged
merged 8 commits into from
Sep 30, 2023
Merged

T16430 logger interpolation #16445

merged 8 commits into from
Sep 30, 2023

Conversation

niden
Copy link
Member

@niden niden commented Sep 29, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added the ability to define interpolator characters for the Phalcon\Logger\Formatter\Line

Thanks

@niden niden added the 5.0 The issues we want to solve in the 5.0 release label Sep 29, 2023
@niden niden requested a review from Jeckerson September 29, 2023 22:57
@niden niden self-assigned this Sep 29, 2023
@niden niden added the new feature request Planned Feature or New Feature Request label Sep 29, 2023
@niden niden changed the base branch from master to 5.0.x September 30, 2023 10:31
@niden niden merged commit 5b60ba8 into phalcon:5.0.x Sep 30, 2023
37 of 38 checks passed
@niden niden deleted the T16430-logger-interpolation branch September 30, 2023 19:39
@niden niden linked an issue Sep 30, 2023 that may be closed by this pull request
[NFR]: Add interpolation placeholders setting for Logger #16430
Closed
@niden niden mentioned this pull request Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeckerson Jeckerson Jeckerson approved these changes

Assignees

@niden niden

Labels
5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NFR]: Add interpolation placeholders setting for Logger
2 participants
@niden @Jeckerson