Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Limited Download Links #2617

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Time Limited Download Links #2617

wants to merge 6 commits into from

Conversation

pglombardo
Copy link
Owner

@pglombardo pglombardo commented Oct 14, 2024

Description

This PR makes file download links to auto expire in 5 minutes and shows a timer on the delivery page.

pwpush-dowload-link-expiration

This will only work when not using local storage. It's the S3/Google/Microsoft cloud storage that allows for signed blob URLs expiration.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've written tests (if applicable) for all new methods and classes that I created. (rake test)
  • I've added documentation as necessary so users can easily use and understand this feature/fix.

@pglombardo pglombardo force-pushed the push-expiration-timer branch from 49e9c8e to 0fbd68f Compare October 15, 2024 00:15
@pglombardo pglombardo changed the title Push: Download links expiration timer Time Limited Download Links Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant