Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant while loop on sub app search #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laky55555
Copy link
Contributor

It looks like while loop around sub app search became redundant.
As far as I can see it won't change code if it is removed.

@pfalcon
Copy link
Owner

pfalcon commented Jul 22, 2019

So, I have to admit that patches like this point to the lack of testsuite in the project. Because well, it took me some 5 mins to remember that the idea was to support black-box functioning of mounted sub-apps, i.e. a user shouldn't be concerned if a webapp it mounts is itself consists of subapps, and thus subapp resolution should be done recursively. This is what the outer while loop handles.

Currently while loop around sub app search is redundant
and can be removed without any negative impacts on codebase.
@pfalcon pfalcon force-pushed the master branch 2 times, most recently from e3acfcc to dbc15e3 Compare December 29, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants