Fix: address feedback for Fedora package #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback by @NeilHanlon from the Fedora package review request upstream here.
It was tedious to get the packaging thing to work alright, I opted for a semi hack in
__init__.py
as for some reason I couldn't get the setuptools packaged with EL to expand smfc.py to a full namespace. Inform me if there's a better way: i'm very much a novice in Python.Multiple Python build system compatibility layers are implemented: that's why there's an
setup.cfg
,setup.py
andpyproject.toml
that all contain the same definitions. This is to get the same behavior across all distros: EL ships with oldsetuptools
and oldpyproject
that don't behave the same as their latest versions would.Split the files for better maintainability and sanity. Currently this does break the Docker support, will fix this before merge (hence it's a draft).
Per feedback I have replaced all
/opt
references with/etc
. The .spec file has further been enhanced to build and test the smfc code. Package has also been split in two:smfc
andpython3-smfc
as dependency.The file structure has been altered to a flat package structure to make pyproject happy. Further several system-wide files have been moved to more descriptive directories.