Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logout logic #617

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix: logout logic #617

merged 1 commit into from
Dec 26, 2024

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Dec 26, 2024

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 5:57am

Copy link

Walkthrough

This pull request addresses the logout logic by implementing a unified logout method across different authentication clients. It introduces a new logout method in the auth0.py, base.py, and local.py files, and modifies the router to utilize this method, ensuring consistent logout behavior and handling of redirect URLs.

Changes

File Summary
server/auth/clients/auth0.py Added a logout method to handle logout requests and redirect logic for Auth0.
server/auth/clients/base.py Introduced an abstract logout method to be implemented by subclasses.
server/auth/clients/local.py Implemented the logout method for local authentication, handling redirect logic.
server/auth/router.py Modified the logout endpoint to use the new logout method from the authentication client.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/auth/clients/auth0.py 16.66% 10 Missing ⚠️
server/auth/clients/local.py 25.00% 3 Missing ⚠️
server/auth/clients/base.py 66.66% 1 Missing ⚠️
server/auth/router.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
server/auth/clients/base.py 51.51% <66.66%> (ø)
server/auth/router.py 36.58% <50.00%> (-1.39%) ⬇️
server/auth/clients/local.py 57.69% <25.00%> (ø)
server/auth/clients/auth0.py 46.93% <16.66%> (ø)

... and 7 files with indirect coverage changes

Copy link
Contributor

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xingwanying xingwanying merged commit 757d37f into main Dec 26, 2024
4 of 5 checks passed
@xingwanying xingwanying deleted the fix/logout-logic branch December 26, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

无法切换 github 账号吗?
2 participants