Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:solve the dup retrieval issue #575

Merged
merged 5 commits into from
Dec 16, 2024
Merged

fix:solve the dup retrieval issue #575

merged 5 commits into from
Dec 16, 2024

Conversation

MadratJerry
Copy link
Contributor

@MadratJerry MadratJerry commented Dec 8, 2024

close issue #531

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 4:45pm

Copy link

Walkthrough

This pull request addresses issue #531 by fixing a duplication retrieval problem in the retrieval.py file. The changes include optimizing database queries to prevent duplicate entries and ensuring minimal record retrieval. Additionally, environment variable management is improved across several modules by centralizing their imports.

Changes

Files Summary
petercat_utils/rag_helper/retrieval.py Optimized database queries to prevent duplicate document retrieval and ensure minimal record overlap.
server/auth/middleware.py, server/auth/router.py, server/github_app/router.py, server/main.py, server/tests/test_main.py Centralized environment variable imports to improve consistency and maintainability.
server/env.py Added a new file to list and manage environment variables.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
server/auth/middleware.py 73.68% 10 Missing ⚠️
petercat_utils/rag_helper/retrieval.py 16.66% 5 Missing ⚠️
Files with missing lines Coverage Δ
server/auth/router.py 38.61% <100.00%> (-2.77%) ⬇️
server/github_app/router.py 41.17% <100.00%> (ø)
server/main.py 92.59% <100.00%> (ø)
server/tests/test_main.py 100.00% <100.00%> (ø)
petercat_utils/rag_helper/retrieval.py 30.30% <16.66%> (ø)
server/auth/middleware.py 77.55% <73.68%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petercat_utils 发个包吧,顺便把toml文件提交一下

# Conflicts:
#	server/auth/router.py
#	server/github_app/router.py
Copy link
Contributor

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xingwanying xingwanying changed the title fix dup retrieval issue fix:solve the dup retrieval issue Dec 16, 2024
@xingwanying xingwanying merged commit 61bd4ef into main Dec 16, 2024
5 checks passed
@xingwanying xingwanying deleted the fix/dup-retrieval branch December 16, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants