-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ed25519::Signature
as the signature type; MSRV 1.60
#6
base: main
Are you sure you want to change the base?
Conversation
Note: this PR doesn't yet impl the |
|
ee8c87e
to
ccc05a9
Compare
81837a1
to
a199ffe
Compare
This is basically good to go with one caveat: I've left the The To land this PR, I would suggest reversing the ordering so they're consistent among the inherent and trait methods ( Another discrepancy is the error type: Another option is to completely remove the inherent methods and always use the traits, although this requires importing them which is a bit more onerous than calling an inherent method. |
Thanks for the bump, sorry I missed this in December! On the argument ordering front, I think we could just swap the argument ordering to be consistent as you suggest, and do a breaking change. On the error front, it seems like there are two options: either (a), change Now that |
We also just shipped |
I yanked Here's a PR to switch to infallible parsing: RustCrypto/signatures#623 |
a199ffe
to
5045a44
Compare
This allows using `ed25519-consensus` in conjunction with the `signature::{Signer, Verifier}` traits. These traits are generic around a signature type parameter which is used to identify a particular signature algorithm, which in this case is `ed25519::Signature`. This type has been used to replace the signature type originally defined in this crate, which is necessary to make `Signer`/`Verifier` work. Uses namespaced features to activate both `dep:serde` and `ed25519/serde`, which requires an MSRV of 1.60. Note this is also the MSRV of `ed25519` v2.1+.
5045a44
to
2ec9dc2
Compare
ed25519::Signature
as the signature type; MSRV 1.60ed25519::Signature
as the signature type; MSRV 1.60
This is ready for review. The I've also changed the argument ordering for |
This allows using
ed25519-consensus
in conjunction with thesignature::{Signer, Verifier}
traits. These traits are generic around a signature type parameter, which in this case ised25519::Signature
.Uses namespaced features to activate both
dep:serde
anded25519/serde
, which requires an MSRV of 1.60. Note this is also the MSRV ofed25519
v2.1+.