Bump NodeJs version on CI, fix compatibility with Node >20 in tests #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,5 +38,5 @@ client.indices.create(req, (err, res) => { | |||
| process.exit(1); | |||
| } | |||
| console.log('[put mapping]', '\t', indexName, res, '\n'); | |||
| process.exit(!!err); | |||
There was a problem hiding this comment.
In the case of error we do process.exit(1) some lines above. This was incompatible with Node >20, because it checks that argument is number and it is not, then throws...
|
@missinglink please take a look when you have a chance 🙏🏻 |
|
Thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
I was working on something and realised that
create_index.jsdoesn't work on modern Node versions... Also decided to update CI to run on Node 18/20/22 and removed Node 16 (let me know if you think it is still needed, but IMO it is too outdated )