Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Spanish street suffix synonyms #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add Spanish street suffix synonyms #393

wants to merge 1 commit into from
+94 −4

Conversation

missinglink
Copy link
Member

today I noticed that we were not able to match the query Av Michoacán against the indexed term Avenida Michoacán

this PR adds Spanish language synonyms for street suffixes.
consider this a living document, please feel free to contribute/edit the file 😃

@missinglink missinglink force-pushed the spanish_street_synonyms branch from 3890add to e8b86a0 Compare December 13, 2019 16:09
@missinglink
Copy link
Member Author

rebased to fix failing tests

orangejulius
orangejulius reviewed Jan 8, 2020
View reviewed changes
synonyms/street_suffix.txt
transversal,trval,trvsal,trval,trvsal
travessera,trav,travesera,trav,travesera
travessia,trv,trav,travesia
via,v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets be sure to test this before we merge it. One character synonyms can probably have large and surprising impacts on both performance and result quality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a different (and quite larger) list for this
https://gist.github.com/bboure/9adb22370bd9b4f794f0d4282662e14f

Source:
https://www.agenciatributaria.es/AEAT.internet/en_gb/Inicio/Ayuda/Tablas_auxiliares_de_domicilios__provincias__municipios____/Tabla_de_Tipos_de_Vias/Tabla_de_Tipos_de_Vias.shtml

Not sure what cost such a large list has and if it is worth it though

@orangejulius
Copy link
Member

Definitely looks like a good thing to add overall.

I made a small note about the via,v synonym. I think single character synonyms can have surprising impact. Are we almost at the point where we want region specific synonyms? As far as I know, that synonym would not be super useful outside Spanish speaking countries, right?

@Joxit Joxit mentioned this pull request Jun 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboure bboure bboure left review comments

@orangejulius orangejulius orangejulius left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@missinglink @orangejulius @bboure